Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface from react-beautiful-dnd #4903

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Add interface from react-beautiful-dnd #4903

merged 2 commits into from
Jun 21, 2021

Conversation

scottybollinger
Copy link
Contributor

Summary

This PR adds an interface to the list of exports from 'react-beautiful-dnd' for use by consumers, without the need to export them from 'react-beautiful-dnd’.

See elastic/kibana#102689

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@scottybollinger
Add interface from react-beautiful-dnd
6fe8b9f 
This PR adds an interface to the list of exports from 'react-beautiful-dnd' for use by consumers, without the need to export them from 'react-beautiful-dnd’.

See elastic/kibana#102689
@scottybollinger scottybollinger mentioned this pull request Jun 21, 2021
Open
thompsongl
thompsongl approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4903/

@scottybollinger scottybollinger merged commit e4f8ae0 into master Jun 21, 2021
@scottybollinger scottybollinger deleted the scottybollinger/react-b-dnd-interface branch June 21, 2021 16:13
@thompsongl thompsongl mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibanamachine @thompsongl